kaxil commented on code in PR #69795:
URL: https://github.com/apache/airflow/pull/69795#discussion_r3574203563
##########
.github/boring-cyborg.yml:
##########
@@ -141,6 +141,9 @@ labelPRBasedOnFilePath:
provider:docker:
- providers/docker/**
+ provider:common-dataquality:
Review Comment:
The other common-* labels sit alphabetically further up (common-ai through
common-sql). This one landed between docker and edge, worth moving next to
common-compat/common-io.
##########
airflow-core/tests/unit/always/test_project_structure.py:
##########
@@ -107,6 +107,7 @@ def test_providers_modules_should_have_tests(self):
"providers/common/compat/tests/unit/common/compat/standard/test_utils.py",
"providers/common/messaging/tests/unit/common/messaging/providers/test_base_provider.py",
"providers/common/messaging/tests/unit/common/messaging/providers/test_sqs.py",
+
"providers/common/dataquality/tests/unit/common/dataquality/test_exceptions.py",
Review Comment:
This entry points at a test for a module this PR doesn't add, there's no
`exceptions.py` in the skeleton, so it's a no-op here. Looks like another
carry-over from #69413, like the .gitignore entries. Since the comment above
says this list should shrink to zero, I'd drop it here and add a real
`test_exceptions.py` when the follow-up brings in `exceptions.py`.
##########
providers/common/dataquality/docs/commits.rst:
##########
@@ -0,0 +1,35 @@
+
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+ .. NOTE! THIS FILE IS AUTOMATICALLY GENERATED AND WILL BE OVERWRITTEN!
+
+ .. IF YOU WANT TO MODIFY THIS FILE, YOU SHOULD MODIFY THE TEMPLATE
+ `PROVIDER_COMMITS_TEMPLATE.rst.jinja2` IN the
`dev/breeze/src/airflow_breeze/templates` DIRECTORY
+
+ .. THE REMAINDER OF THE FILE IS AUTOMATICALLY GENERATED. IT WILL BE
OVERWRITTEN!
+
+Package apache-airflow-providers-common-dataquality
+------------------------------------------------------
+
+``Data Quality Provider``
+
+
+This is detailed commit list of changes for versions provider package:
``dataquality``.
Review Comment:
The template renders the provider id here, so regeneration would produce
``common.dataquality`` (compare common/ai and common/io), and the description
line above would be "Common Data Quality Provider" from provider.yaml. Worth
matching the generated output so the first release prep doesn't produce a diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
