srchilukoori commented on PR #65840:
URL: https://github.com/apache/airflow/pull/65840#issuecomment-4963952365

   > Hmm:
   > 
   > > airflow-site is the source of truth. When a new theme version is 
published, upgrade_important_versions.py bumps **version** in **init**.py, 
which triggers fetch_theme_assets.py to re-extract all theme files (templates + 
_gen/ assets) from the new wheel. No reverse sync, no local asset builds.
   > 
   > When I look at that - I think we should do locoal building of assets in 
airflow repo (it's really needed when you want to locally modiy the theme and 
see it "live" - that was the main motivation of the change. I do not think they 
should be pulled from wheel - it does not solve any issue to be honest.
   
   @potiuk Having the site files in this repo, would lead to code divergence 
between the site and the airflow repository. Are you planning to merge the 
airflow-site into this repository? The current state (in this PR) is keeping 
the airflow-site as SOT, and pulling new versions when there are updates to 
airflow-site.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to