nailo2c commented on code in PR #69426:
URL: https://github.com/apache/airflow/pull/69426#discussion_r3575465457
##########
airflow-core/docs/templates-ref.rst:
##########
@@ -107,6 +107,7 @@ Variable Type
Description
``{{ expanded_ti_count }}`` int | ``None`` | Number of
task instances that a mapped task was expanded into. If
| the
current task is not mapped, this should be ``None``.
| Added in
version 2.5.
+``{{ extra_links }}`` ExtraLinksAccessor Accessor for
operator extra links defined on the task. Added in version 3.4.
Review Comment:
I'm afraid that adding `extra_links` as a new context key may affect
existing TaskFlow tasks that already use `extra_links` as a normal task
argument.
For example, this kind of Dag may start failing because `extra_links`
becomes a reserved context key:
```python
@task
def my_task(extra_links=[]):
...
my_task.expand(extra_links=[...])
```
Looking at the other variables in this doc, I think all of them are specific
enough. Perhaps we need a regression test or a more specific context key name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
