Vamsi-klu commented on PR #69786: URL: https://github.com/apache/airflow/pull/69786#issuecomment-4966077404
Confirmed the gap: `AirbyteSyncTrigger.run()` can yield `cancelled` events and the old `execute_complete` only raised on `status == "error"`, so a cancelled job fell straight through to the success log. The new `event["status"] != "success"` guard closes that and matches `poke()`, which already raises on a cancelled job. One nit: the branch right above still raises `AirflowException` while the new one raises `RuntimeError` (that does line up with the sibling `AirbyteTriggerSyncOperator.execute_complete`), so this method now throws two different types depending on the path, worth a look if you care about consistency. Small thing on the comment too, `execute()` here defers without passing `execution_deadline`, so the trigger's `timeout` status can't actually fire for this sensor, though the catch-all still handles it fine. Tests cover the cancelled and fail-closed cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
