Vamsi-klu commented on PR #69846:
URL: https://github.com/apache/airflow/pull/69846#issuecomment-4966077688
The `if self.database:` guard in `execute()` looks right, it skips writing
`Database` into `query_execution_context` when the arg is unset instead of
forcing a `None` in there, and defaulting the signature to `database: str |
None = None` leaves existing keyword callers alone. Nice that
`fallback_database = self.database or
self.query_execution_context.get("Database")` keeps the OpenLineage schema
resolution working when the database only arrives through the execution
context. One subtle behavior maybe worth a docstring line: with `database=None`
and a `query_execution_context` that already sets `Database`, `execute()` now
preserves that value instead of overwriting it, which looks like the right call
but is easy to miss. The two new tests cover the no database run and the
context fallback, so this looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
