Copilot commented on code in PR #69864: URL: https://github.com/apache/airflow/pull/69864#discussion_r3580125586
########## airflow-core/src/airflow/models/dag_version.py: ########## @@ -40,6 +41,13 @@ log = logging.getLogger(__name__) +SourceStatus = Literal["current_stored_code", "redacted", "unavailable"] +ValuesStatus = Literal["available", "unavailable"] + + +class DagVersionNotFoundError(ValueError): + """Raised when one of the requested Dag versions does not exist.""" + Review Comment: `DagVersionNotFoundError` is very close in meaning/name to the existing `airflow.exceptions.DagVersionNotFound` (used in other parts of the codebase). Having two similarly named exceptions for “DagVersion missing” increases ambiguity for callers and error handling (which one should API/CLI layer catch/translate?). Consider reusing `DagVersionNotFound` or renaming this exception to be more specific to this method (and updating tests accordingly). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
