Miretpl commented on code in PR #69469: URL: https://github.com/apache/airflow/pull/69469#discussion_r3580238208
########## chart/values.yaml: ########## @@ -442,12 +442,12 @@ data: # connection: base64_encoded_connection_string # # The 'connection' key is base64-encoded SQLAlchemy connection string, e.g.: - # postgresql+psycopg2://airflow:password@postgres/airflow + # postgresql+psycopg://airflow:password@postgres/airflow metadataSecretName: ~ # If not set, falls back to metadataSecretName. The secret must contain 'connection' key which is # a base64-encoded connection string, e.g.: - # postgresql+psycopg2://user:password@host/db + # postgresql+psycopg://user:password@host/db Review Comment: Helm Chart on main supports Airflow > 3.1 version (as far as I remember, it will not work on 3.1) and 1.2x line supports >=2.11. Could you adjust the comment here so that it shows which version supports what? It would also be good to do a manual backport of this file to the `chart/v1-2x-test` branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
