Miretpl commented on code in PR #69703:
URL: https://github.com/apache/airflow/pull/69703#discussion_r3580258815
##########
chart/newsfragments/69703.feature.rst:
##########
@@ -0,0 +1 @@
+Add ``dags.gitSync.metrics`` option to expose the git-sync metrics port
Review Comment:
I think that a normal commit message in the release notes will be good
enough. Could you remove that file?
##########
chart/tests/helm_tests/other/test_git_sync_scheduler.py:
##########
@@ -126,6 +126,44 @@ def test_validate_the_git_sync_container_spec(self):
},
}
+ def test_metrics_port_added_when_metrics_enabled(self):
+ docs = render_chart(
+ values={
+ "executor": "LocalExecutor",
Review Comment:
Could we test it for other executors too?
##########
chart/values.yaml:
##########
@@ -3518,6 +3518,10 @@ dags:
# use a dedicated Git-Sync liveness service. In future, behaviour with
value true will be
# default one and old one will be removed
recommendedProbeSetting: false
+ # Expose git-sync metrics by adding a named container port.
+ # Requires the git-sync http server, which is bound on httpPort.
+ metrics:
+ enabled: false
Review Comment:
```suggestion
# Expose git-sync metrics by adding a named container port.
# Requires the git-sync http server, which is bound on httpPort.
metrics:
enabled: false
```
##########
chart/templates/_helpers.yaml:
##########
@@ -304,12 +304,23 @@ If release name contains chart name it will be used as a
full name.
value: ":{{ .Values.dags.gitSync.httpPort }}"
- name: GITSYNC_HTTP_BIND
value: ":{{ .Values.dags.gitSync.httpPort }}"
+ {{- if .Values.dags.gitSync.metrics.enabled }}
+ - name: GIT_SYNC_HTTP_METRICS
+ value: "true"
+ - name: GITSYNC_HTTP_METRICS
+ value: "true"
Review Comment:
Is metrics server a thing for 3rd version of GitSync?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
