kacpermuda commented on code in PR #69874:
URL: https://github.com/apache/airflow/pull/69874#discussion_r3587780895
##########
airflow-core/src/airflow/api/common/mark_tasks.py:
##########
Review Comment:
Good spot ! Thanks, excluded teardown tasks now.
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##########
@@ -1609,6 +1609,70 @@ def test_patch_dag_run_notifies_listeners(self,
test_client, state, listener_sta
assert response.status_code == 200
assert listener.state == listener_state
+ @pytest.mark.parametrize(
+ ("dag_run_state", "expected_ti_listener_state"),
+ [
+ ("success", TaskInstanceState.SUCCESS),
+ ("failed", TaskInstanceState.FAILED),
+ ],
+ )
+ @pytest.mark.usefixtures("configure_git_connection_for_dag_bundle")
+ def test_patch_dag_run_notifies_ti_listeners_for_running_tasks(
+ self,
+ test_client,
+ dag_maker,
+ session,
+ listener_manager,
+ dag_run_state,
+ expected_ti_listener_state,
+ ):
Review Comment:
Added a separate tests for teardown case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
