amoghrajesh commented on code in PR #69914:
URL: https://github.com/apache/airflow/pull/69914#discussion_r3593959271
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -170,8 +176,14 @@ class KubernetesPodOperator(BaseOperator):
:param in_cluster: run kubernetes client with in_cluster configuration.
:param cluster_context: context that points to kubernetes cluster.
Ignored when in_cluster is True. If None, current-context is used.
(templated)
- :param reattach_on_restart: if the worker dies while the pod is running,
reattach and monitor
- during the next try. If False, always create a new pod for each try.
+ :param reattach_on_restart: deprecated, use ``durable`` instead. If the
worker dies while the pod
+ is running, reattach and monitor during the next try. If False, always
create a new pod for
+ each try.
Review Comment:
Handled in 325a931486e
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -170,8 +176,14 @@ class KubernetesPodOperator(BaseOperator):
:param in_cluster: run kubernetes client with in_cluster configuration.
:param cluster_context: context that points to kubernetes cluster.
Ignored when in_cluster is True. If None, current-context is used.
(templated)
- :param reattach_on_restart: if the worker dies while the pod is running,
reattach and monitor
- during the next try. If False, always create a new pod for each try.
+ :param reattach_on_restart: deprecated, use ``durable`` instead. If the
worker dies while the pod
+ is running, reattach and monitor during the next try. If False, always
create a new pod for
+ each try.
+ :param durable: if the worker dies while the pod is running, reattach and
monitor during the next
+ try instead of creating a duplicate pod. If False, always create a new
pod for each try.
+ Supersedes ``reattach_on_restart``; on Airflow 3.3+ the reconnection
uses a persisted pod
+ identity in task state store instead of a label search, removing the
ambiguity failure a label
+ search can hit when more than one matching pod exists. Defaults to
``True``.
Review Comment:
Handled in 325a931486e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
