amoghrajesh commented on code in PR #69916:
URL: https://github.com/apache/airflow/pull/69916#discussion_r3595110249
##########
shared/logging/src/airflow_shared/logging/structlog.py:
##########
@@ -718,6 +721,8 @@ def is_atty():
}
logging.config.dictConfig(config)
+ for logger_name, level in parsed_namespace_log_levels.items():
+ logging.getLogger(logger_name).setLevel(level)
Review Comment:
`logging.getLogger(logger_name).setLevel(level)` sets a stdlib logger level
directly on the global logger object, outside `dictConfig`. Once set, it stays
set on that logger for the rest of the process & a later `configure_logging()`
call that does not mention that same logger name will not reset it back. Seems
like a quirk we should be aware about or handle in `dictConfig`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
