dabla opened a new pull request, #69969:
URL: https://github.com/apache/airflow/pull/69969
…ets-backend aliases
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Fix `PydanticAIHook.get_hook` losing the caller's `conn_id` with
secrets-backend aliases
### Problem
When a secrets backend (e.g. HashiCorp Vault) stores a connection under an
**alias** (`my-llm`) that it maps to a canonical id (`openai-prod`) on
retrieval,
the `Connection` object returned by `get_connection("my-llm")` carries
`conn_id = "openai-prod"`.
`BaseHook.get_hook` passes that `Connection` straight to
`connection.get_hook()`,
which instantiates the hook with `llm_conn_id = "openai-prod"`. Any
subsequent
call to `hook.get_conn()` (e.g. inside `LLMOperator` / `@task.agent`) then
tries
to fetch `"openai-prod"` from the secrets backend — a key it does not
recognise —
and raises `AirflowNotFoundException`.
### Fix
Override `get_hook` in `PydanticAIHook` to call `super().get_hook()` and then
immediately restore the **caller's original `conn_id`** on the hook via
`setattr(hook, hook.conn_name_attr, conn_id)`.
```python
@classmethod
def get_hook(cls, conn_id: str, hook_params: dict | None = None) ->
PydanticAIHook:
hook = super().get_hook(conn_id, hook_params=hook_params)
setattr(hook, hook.conn_name_attr, conn_id)
return hook
```
This is the minimal, non-invasive fix: the parent class resolves and
constructs
the hook as usual; the single `setattr` re-keys it to the queryable alias
before
it is returned to the caller.
### Impact
- Unblocks `LLMOperator` and `@task.agent` when connections are stored under
alias keys in any secrets backend.
- No behaviour change when the secrets backend does not rewrite `conn_id`
(the `setattr` is a no-op in that case).
- No changes to `BaseHook` or the secrets-backend infrastructure.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ x ] Yes (please specify the tool below)
Claude Sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
