bileyroy commented on code in PR #69879:
URL: https://github.com/apache/airflow/pull/69879#discussion_r3596603841
##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -490,6 +517,8 @@ def _cleanup_table(
extra_filters: list[Any] | None = None,
skip_if_referenced: list[tuple[str, str]] | None = None,
referenced_pk_column: str = "id",
+ fallback_recency_column=None,
Review Comment:
@bugraoz93 so this `fallback_recency_column` is part of `_TableConfig`
([here](https://github.com/apache/airflow/pull/69879/changes#diff-0f691d24c54a28756110b2d9125bb06a3d8862333977ef86ec30ad33220440c8R162))
and is derived in `__post_init__` (same pattern as `recency_column` which is
also derived there from `recency_column_name`). It is not passed explicitly,
but coming from `**table_config.__dict__`
[here](https://github.com/apache/airflow/pull/69879/changes#diff-0f691d24c54a28756110b2d9125bb06a3d8862333977ef86ec30ad33220440c8R763).
Computing it inside `_cleanup_table()` would be redundant since
`__post_init__` already does this derivation once at config initialization time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
