seanghaeli commented on code in PR #69574:
URL: https://github.com/apache/airflow/pull/69574#discussion_r3598050346
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_cluster.py:
##########
@@ -864,15 +867,18 @@ def __init__(
self.final_cluster_snapshot_identifier =
final_cluster_snapshot_identifier
self.wait_for_completion = wait_for_completion
self.poll_interval = poll_interval
- # These parameters are added to keep trying if there is a running
operation in the cluster
- # If there is a running operation in the cluster while trying to
delete it, a InvalidClusterStateFault
- # is thrown. In such case, retrying
- self._attempts = 10
+ # Retry the delete while the cluster is mid-transition
(InvalidClusterStateFault) until it
+ # settles into a deletable state.
+ self._attempts = 60
Review Comment:
Good point, no reason except for the fact that we were using `self._attempt`
before. Updated to use `max_attempts` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
