Vamsi-klu commented on PR #69847: URL: https://github.com/apache/airflow/pull/69847#issuecomment-5000004306
The component change itself looks like the right small fix: the switch needs both a full-width root and `justifyContent="flex-end"` to reach the right edge of the existing control column. I think a few follow-ups are needed before this is ready, though. The new test only checks `justifyContent`; it would still pass if `width="full"` were removed, even though that restores the alignment problem. Could you cover both props—for example, by capturing the props passed to the shared `Switch`? The long-title fixture currently does not exercise that layout because the test mounts `FieldBool` directly; either render through `FieldRow` for long-label coverage or remove that unused setup. Please also replace the new `Record<string, any>`/ESLint suppression with a narrow type, rename the newsfragment to `69847.bugfix.rst`, and complete the PR and commit subjects without the `fix:` prefix. The requested before/after screenshots are still needed, and `airflow dags test` does not validate this React UI change; a targeted Vitest run plus UI lint/type-check would be relevant validation. --- Drafted-by: Codex (GPT-5); reviewed by @Vamsi-klu before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
