kjh0623 commented on PR #70003: URL: https://github.com/apache/airflow/pull/70003#issuecomment-5003167176
Thanks for the review @ephraimbuddy — you're right, LocalDagBundle already covers the git-sync pattern the same way the Airflow 2 dags folder did, so a new bundle class was unnecessary. I reworked the PR as you suggested: the GitSyncDagBundle class is removed, and the symlink pinning is now an opt-in pin_symlink_on_refresh flag on LocalDagBundle (default False, so no behavior change for existing users). On your note about workers: correct — each component (dag processor, worker, triggerer) resolves the symlink when it initializes the bundle, so pinning gives per-process consistency (one parse round or one task run), not global consistency. I documented that scope, plus the git-sync --stale-worktree-timeout recommendation, in the dag-bundles docs. PTAL when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
