xBis7 opened a new pull request, #70014:
URL: https://github.com/apache/airflow/pull/70014
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
PR https://github.com/apache/airflow/pull/68082 was discussed during the
community call on Thursday July 16 and based on the feedback, the name listener
is confusing to everyone not familiar with the code.
The existing Kafka Listener, implements the Airflow listener API and on
every state change event, it produces a message to a Kafka topic. Therefore,
the plugin has dual purpose and it acts as a listener to Airflow events and a
producer to Kafka.
The name is fine for internal use in the code but the plugin has been
documented and when users will read about it, they will be confused and might
wrongfully associate it with an AssetWatcher.
An AssetWatcher is on the consumer side, while the plugin is on the producer
side.
This patch changes the name to `Asset Producer`. The existing classes
`DagRunListener` and `TaskInstanceListener` have deliberately stayed the same
because they implement Airflow's listener API and the listener suffix makes
sense.
I've also included a section in the docs with common use cases for the
plugin so that it's clear for users when to enable it.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes
Claude-code Opus 4.7
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
