VladaZakharova opened a new pull request, #68833:
URL: https://github.com/apache/airflow/pull/68833

   In Breeze / community Airflow, there are several types of auth managers that 
have different sets of fields, which actually leads to different data stored to 
DB about the user.
   The default auth manager is usually SimpleAuthManager. It only knows simple 
login data like:
   - username
   - role
   - password
   
   For example:
   username: admin
   role: admin
   password: admin
   
   So in default Breeze, the new column will look the same as old one:
   User: admin.
   User Display Name: admin.
   
   The other one that can be also used is FAB manager. Available fields are:
   - username
   - first_name
   - last_name
   - email
   - password
   - role
   - 
   The common solution will be for different auth managers like this:
   
   ```For every audit log row:
   
      If first_name and last_name exist:
          show "first_name last_name"
   
      Else if email exists:
          show "email"
   
      Else:
          show "username"
   ```
   
   Example:
   first_name = Jane.
   last_name = Smith.
   email = [[email protected]](mailto:[email protected]).
   username = jane.
   
   User = jane.
   User Display Name = Jane Smith.
   
   Or:
   first_name = empty.
   last_name = empty.
   email = [[email protected]](mailto:[email protected]).
   username = jane.
   
   User = jane.
   User Display Name = [[email protected]](mailto:[email protected]).
   
   This change will make the Audit log more informative for users. 
   Example how it will look like:
   <img width="898" height="692" alt="Screenshot 2026-06-17 at 12 53 38" 
src="https://github.com/user-attachments/assets/4d962b39-d917-48da-98d8-6503bf932488";
 />
   
   The change is implemented as a new Column in Audit Logs tab, which can be 
also hidden in side menu by user, if preferred to not be shown.
   
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   
   <!-- pr-triage-fold: triaged=2026-07-11T14:59:47Z head=88661f8 action=draft 
-->
   
   ---
   
   > [!IMPORTANT]
   > **🛠️ Maintainer triage note for @VladaZakharova** · by `@potiuk` · 
2026-07-11 14:59 UTC
   >
   > Helpful heads-up from the maintainers — please address before this PR can 
be reviewed (see our [Pull Request quality 
criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria)):
   > - :x: **Pre-commit / static checks**. See 
[docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst).
   >
   > **The ball is in your court** — you've been assigned to this PR. Fix the 
above, then mark it **Ready for review**.
   >
   > <sub>_Automated triage — may be imperfect; a maintainer takes the next 
look._</sub>
   
   <!-- /pr-triage-fold -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to