luisglft opened a new pull request, #70048:
URL: https://github.com/apache/airflow/pull/70048
## Summary
#52130 added `defaultValues={["downstream"]}` to the shared
`SegmentedControl` (Past/Future/Upstream/Downstream) used by both
`ClearTaskInstanceDialog` and `MarkTaskInstanceAsDialog`.
- For **Clear Task Instance**, this was correct: that dialog's own state
already hardcoded `useState(["downstream"])` before #52130 — the PR only fixed
a display bug where the button looked unselected despite downstream already
being included in the clear request.
- For **Mark Task Instance As**, this is a real regression: before #52130,
nothing was selected by default, so marking a task as success/failed only
affected that task. Now "Downstream" is selected by default, so marking a task
also marks its downstream task instances with the same state — but **without
executing them**, since Mark-As sets state directly rather than running
anything. This silently short-circuits the DAG for anyone who doesn't notice
and manually deselect "Downstream" before confirming.
This PR removes the `defaultValues={["downstream"]}` prop from
`MarkTaskInstanceAsDialog` only, restoring the pre-#52130 opt-in default.
`ClearTaskInstanceDialog` is untouched.
## Test plan
- [ ] Open "Mark Task Instance as success/failed" on a task instance —
confirm no options are pre-selected.
- [ ] Open "Clear Task Instance" on a task instance — confirm "Downstream"
is still pre-selected (unchanged).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
