nagasrisai commented on code in PR #70041: URL: https://github.com/apache/airflow/pull/70041#discussion_r3607482438
########## airflow-core/src/airflow/dag_processing/manager.py: ########## Review Comment: That change is not part of this PR. Our fork's main branch is one commit behind upstream main, so the diff picks up pre-existing upstream changes as noise. The `deque → OrderedDict` swap was already on upstream main before this branch was cut. Our only change to `manager.py` is the addition of the early-return guard and the `stats.decr` call inside `_collect_results()` (∼12 lines). ########## airflow-core/src/airflow/dag_processing/manager.py: ########## Review Comment: Same situation here — the multi-line import expansions are pre-existing upstream changes, not added by this PR. They appear in the diff only because our fork base is slightly behind upstream. Our only import addition is `from airflow.utils.helpers import prune_dict`, which was already needed by the existing metric calls in the file and follows the single-line style. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
