jason810496 commented on code in PR #69965:
URL: https://github.com/apache/airflow/pull/69965#discussion_r3608514915
##########
go-sdk/bundle/bundlev1/registry.go:
##########
@@ -20,13 +20,34 @@ package bundlev1
import (
"fmt"
"reflect"
+ "regexp"
"runtime"
"strings"
"sync"
+ "unicode/utf8"
"github.com/apache/airflow/go-sdk/pkg/worker"
)
+const maxKeyLength = 250
+
+var keyRegex = regexp.MustCompile(`^[\p{L}\p{N}_.-]+$`)
Review Comment:
IIUC, the `a..b` case can pass the validation. Perhaps it's worthwhile to
add the unit test to exercise. Thanks.
https://github.com/apache/airflow/blob/ffde96203e76c0c27ccf1ae6eeaad270653248bf/airflow-core/src/airflow/serialization/definitions/dag.py#L637-L648
##########
go-sdk/bundle/bundlev1/registry.go:
##########
Review Comment:
We should also validate the `AddTask` call here. Since we will pass the
generic function name itself as the taskID name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
