SameerMesiah97 commented on code in PR #70067:
URL: https://github.com/apache/airflow/pull/70067#discussion_r3609698596
##########
providers/google/src/airflow/providers/google/common/hooks/base_google.py:
##########
@@ -436,7 +436,7 @@ def is_default_universe() -> bool:
@staticmethod
def get_high_value_cookie_domain() -> str:
- return os.getenv("GOOGLE_CLOUD_HIGH_VALUE_COOKIE_DOMAIN", "google.com")
+ return os.getenv("GOOGLE_CLOUD_HIGH_VALUE_COOKIE_DOMAIN") or
"google.com"
Review Comment:
This works but it could be clearer. Please see the below:
```
domain = os.getenv("GOOGLE_CLOUD_HIGH_VALUE_COOKIE_DOMAIN")
return "google.com" if domain in (None, "") else domain
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
