yuseok89 commented on PR #69875: URL: https://github.com/apache/airflow/pull/69875#issuecomment-5014638701
@bbovenzi Thanks for the review. That makes sense to me. I think a time range is the right direction, so I prototyped two ways of adding it. A standalone time-range select in the filter bar could read as a page-wide filter, so both attach the time axis to the run-state filter itself. Agreed that searching for "ever had a success" is unrealistic. I had added `success` for symmetry with "Last run state". With a time window attached though, something like "Dags with a successful run in the last 24 hours" does become meaningful. Before the backend details, I'd like to settle the UI direction first. Two options: **Option A — attach a time window to the existing "Any run" filter** https://github.com/user-attachments/assets/9315fb59-6c8f-43ef-ba41-cffa4133889b When a state is selected, a `within:` segment appears joined to the same control(Last 24 hours / 7 days / 30 days / Any time). It defaults to **Last 7 days**, so the "very old failures" concern is addressed by the default behavior. **Option B — merge the two run-state filters into one** https://github.com/user-attachments/assets/009d1678-465d-495f-9756-0863416e391b Going a step further. Having "Last run state" and "Any run state" side by side is itself a bit confusing, so this merges them into a single `Run state` control with a scope (`Latest run` / Last 24 hours / 7 days / 30 days / `Any time`). Later, adding an "Any state" entry would cover "dags with any runs in the last 24 hours" with the same control. My preference is **B** . It removes the confusion of the two coexisting filters and covers both use cases you mentioned with one model. It does grow the scope of the change, though. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
