jason810496 commented on code in PR #69328:
URL: https://github.com/apache/airflow/pull/69328#discussion_r3610128586
##########
.github/workflows/additional-prod-image-tests.yml:
##########
@@ -338,6 +342,18 @@ jobs:
e2e_test_mode: "go_sdk"
if: inputs.canary-run == 'true' || inputs.run-go-sdk-e2e-tests == 'true'
+ test-e2e-integration-tests-ts-sdk:
+ name: "TypeScript SDK e2e tests with PROD image"
Review Comment:
It would be nice to follow the https://github.com/apache/airflow/pull/69794,
https://github.com/apache/airflow/pull/69909 convention to build the ts-sdk
example natively in CI.
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -271,6 +271,13 @@ def __hash__(self):
r"^airflow-e2e-tests/tests/airflow_e2e_tests/constants\.py$",
r"^airflow-e2e-tests/docker/openlineage-compat\.Dockerfile$",
],
+ FileGroupForCi.TS_SDK_E2E_FILES: [
+ r"^ts-sdk/.*",
+ r"^airflow-e2e-tests/tests/airflow_e2e_tests/ts_sdk_tests/.*",
+ r"^airflow-e2e-tests/docker/ts\.yml$",
+ r"^task-sdk/src/airflow/sdk/coordinators/_subprocess\.py$",
+ r"^task-sdk/src/airflow/sdk/coordinators/node/.*",
+ ],
Review Comment:
We should exclude the .md change for ts-sdk e2e test.
https://github.com/apache/airflow/blob/ffde96203e76c0c27ccf1ae6eeaad270653248bf/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L249-L256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
