justinpakzad opened a new pull request, #70103:
URL: https://github.com/apache/airflow/pull/70103
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
**Description**
Follow-up to #68259 adding deferrable mode to SnowparkContainerJobOperator.
Snowpark Container jobs are often long-running (ML training, batch processing,
other containerized workloads that run for hours), which makes them a good fit
for deferrable mode.
The SnowflakeHook is synchronous, so this follows a similar approach the
Anthropic provider took. The trigger wraps each blocking hook call in
asyncio.to_thread so a single poll doesn't stall the shared triggerer event
loop. A timeout parameter is introduced for both modes. Cleanup is consistent
across both modes, on timeout the service is dropped to stop billing on a job
past its deadline. On poll errors and terminal failures it's left in place for
inspection.
The status Enum and terminal/non-terminal frozensets were moved to the
trigger file so the operator can import them without a circular dependency.
**Testing**
- Unit tests for the trigger (serialization,
terminal/unexpected/timeout/error events, cleanup) and the operator's defer and
execute_complete paths.
- Manually tested end-to-end against a real Snowflake account: deferred
success (job completes, logs retrieved, service dropped), terminal failure,
both timeout types, on_kill, and the drop toggles.
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (Claude Opus 4.6)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
