This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 4c1ce4e3ff3 Refactor get_statsd_logger to use keyword arguments for
clarity and add a test for ipv6 support in StatsD logger (#69632)
4c1ce4e3ff3 is described below
commit 4c1ce4e3ff3708b34bfd666b24526a5f07c57cc4
Author: ykuc <[email protected]>
AuthorDate: Mon Jul 20 00:19:34 2026 +0200
Refactor get_statsd_logger to use keyword arguments for clarity and add a
test for ipv6 support in StatsD logger (#69632)
---
.../src/airflow_shared/observability/metrics/statsd_logger.py | 7 ++++++-
shared/observability/tests/observability/metrics/test_stats.py | 7 +++++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git
a/shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py
b/shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py
index 3500a04dc7b..b5f39777241 100644
---
a/shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py
+++
b/shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py
@@ -170,7 +170,12 @@ def get_statsd_logger(
statsd_influxdb_enabled: bool = False,
) -> SafeStatsdLogger:
"""Return logger for StatsD."""
- statsd = stats_class(host, port, prefix, ipv6)
+ statsd = stats_class(
+ host=host,
+ port=port,
+ prefix=prefix,
+ ipv6=ipv6,
+ )
metric_tags_validator = PatternBlockListValidator(statsd_disabled_tags)
validator = get_validator(metrics_allow_list, metrics_block_list)
diff --git a/shared/observability/tests/observability/metrics/test_stats.py
b/shared/observability/tests/observability/metrics/test_stats.py
index 4121ffe9eee..04f2731248a 100644
--- a/shared/observability/tests/observability/metrics/test_stats.py
+++ b/shared/observability/tests/observability/metrics/test_stats.py
@@ -64,6 +64,13 @@ def get_statsd_logger_factory(
)
+class TestGetStatsdLogger:
+ @mock.patch("statsd.StatsClient")
+ def test_passes_ipv6_as_keyword(self, mock_stats_client):
+ statsd_logger.get_statsd_logger(stats_class=mock_stats_client,
ipv6=True)
+ assert mock_stats_client.call_args.kwargs["ipv6"] is True
+
+
class TestStats:
def setup_method(self):
self.statsd_client = Mock(spec=statsd.StatsClient)