shahar1 commented on PR #70059:
URL: https://github.com/apache/airflow/pull/70059#issuecomment-5021905954

   > @shahar1 In general terms, showing task level code from different 
languages in the UI requires a new AIP -- right now the way dag code is stored 
doesn't and the UI handles it doesn't allow it, nor does dag processing provide 
a means to record it, so this counts to me as a Architectural Change -> AIP 
worthy.
   > 
   > (I agree that it would be nicer, but we don't have the plumbing to set it 
up) 
   
   Didn't claim otherwise - it will definitely require its on AIP and design, 
and they don't have to be included in the scope of the current AIPs.
   My main concerns were:
   
   1. In general, hard "no-go" design decisions should be scoped (what + why), 
and have a discussion and lazy-consensus in the dev list, as they become hard 
to challenge and revert at later stage by nature.
   
   2. Specifically this ADR, as written by the time I reviewed, might be 
interpreted as "no-go" for any kind of more granular implementation, which 
might be a useful feature. I also talked later with Jason in private and he 
suggested his own idea for implementing it later on. Also, this decision 
affects other SDKs, so other stakeholders might have their opinions on it.
   
   In any case, considering that there's an agreement that task-level 
implementation could be considered in later stage with its own AIP - I'm 
removing the blocker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to