pierrejeambrun opened a new pull request, #70126:
URL: https://github.com/apache/airflow/pull/70126
Follow-up to #67381.
The `GET /backfills/{backfill_id}/dag_runs` endpoint added in #67381 relies
on `joinedload` to keep its query count constant, but its tests didn't assert
that — so a change that drops the eager-load could silently reintroduce an N+1.
- Add an `assert_queries_count(5)` guard on the happy-path test. Verified
the count is constant: 2 dag runs and 6 dag runs both issue 5 queries, so
nothing scales with the number of rows.
- Let the test client encode the query parameters from a native `dict`
(`params={...}`) instead of hand-building `?limit=...&offset=...` /
`?order_by=...` strings, so the client handles the encoding.
Test-only change.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.8)
Generated-by: Claude Code (Opus 4.8) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
