pierrejeambrun commented on code in PR #68616:
URL: https://github.com/apache/airflow/pull/68616#discussion_r3614714911
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -685,9 +685,27 @@ def list(
job_type: str | None = None,
hostname: str | None = None,
is_alive: bool | None = None,
+ dag_id: str | None = None,
+ state: str | None = None,
+ limit: int | None = None,
+ offset: int | None = None,
+ order_by: str | None = None,
) -> JobCollectionResponse | ServerResponseError:
"""List all jobs."""
- params = _build_query_params(job_type=job_type or None,
hostname=hostname or None, is_alive=is_alive)
+ params = _build_query_params(
+ job_type=job_type or None,
+ hostname=hostname or None,
+ is_alive=is_alive,
+ dag_id=dag_id or None,
+ job_state=state or None,
+ order_by=order_by or ("-start_date" if limit is not None else
None),
Review Comment:
Not sure here about changing the order_by default value based on if the
`limit` provided or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
