hussein-awala commented on code in PR #68584:
URL: https://github.com/apache/airflow/pull/68584#discussion_r3615069817
##########
airflow-core/newsfragments/68584.bugfix.rst:
##########
Review Comment:
no need for a newsfragment, it is only needed when there is a significant
change
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -941,7 +941,13 @@ def _process_log_messages_from_subprocess(self) ->
Generator[None, bytes | bytea
from airflow.sdk.log import configure_logging
- configure_logging()
+ # Must match the json_logs setting: calling configure_logging() here
reconfigures
+ # structlog globally. Defaulting json_output to False would install
the text
+ # WriteLogger factory, while the stdout/stderr forwarders
(forward_to_log) emit
+ # bytes from the JSON renderer -- crashing the triggerer with
+ # "TypeError: can't concat str to bytes" the first time a trigger
subprocess
+ # writes to stdout/stderr.
Review Comment:
I believe the comment is useless (mostly auto-added by AI agent), it could
be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
