dheerajturaga commented on PR #70095: URL: https://github.com/apache/airflow/pull/70095#issuecomment-5025956213
> > Actually on second pass, the current approach is better. Could we rename this option from `--name-pattern` to `--worker-name-pattern`? > > The command output and model field both use `worker_name`, and the edge API/UI already expose `worker_name_pattern`, so `--worker-name-pattern` makes the target field clearer. I'd avoid extending `--edge-hostname` for this, since that option is used as an exact worker identity for mutation commands. > > Drafted-by: Codex (GPT-5); reviewed by @dheerajturaga before posting > > I gave it a thought before raising this PR, but > > `airflow edge list-workers --worker-name-pattern PATTERN` > > sounds bit redundant on the worker side, so thought of going with just name-pattern since here name self explains it is for worker, let me know what do you think? just incase we want to use the same option for other edge CLIs it would make it clear -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
