potiuk commented on code in PR #69790:
URL: https://github.com/apache/airflow/pull/69790#discussion_r3622583172
##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -365,6 +365,28 @@ def is_authorized_view(
:param user: the user to performing the action
"""
+ def is_authorized_view_for_team(
Review Comment:
Hmm. I do not think we can have such a breaking change in Auth Manager, the
issue is that if the previous Auth Managera (for exampl current AWS provider)
would be used with the new Airflow - it would raise 500 when the view for
import errors is called - simply because we try to run the method with
`team_name`.
So I updated it this way now. Let me know what you think. It does add
"back-compat" code that is not "beautiful" - but I think we cannot just make
the older versions of auth managers to stop working ?
We need to bite this bullet I guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
