[
https://issues.apache.org/jira/browse/AIRFLOW-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008409#comment-17008409
]
ASF GitHub Bot commented on AIRFLOW-6475:
-----------------------------------------
potiuk commented on pull request #7065: [AIRFLOW-6475] Remove duplication of
volume mount specs in Breeze..
URL: https://github.com/apache/airflow/pull/7065
We had two sets of duplicated local volume mounts - one for ./breeze
interactive runs (with docker_compose) and the other with scripts that are
used
to run static checks.
The volumes from the .yaml for docker compose are now the "source of truth"
and the bash script parses the yaml and useis volume mounts from there.
---
Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6475
- [x] Description above provides context of the change
- [x] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA
ID*
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
(*) For document-only changes, no JIRA issue is needed. Commit message
starts `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove duplicated volume mounts in Breeze
> -----------------------------------------
>
> Key: AIRFLOW-6475
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6475
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ci
> Affects Versions: 2.0.0, 1.10.7
> Reporter: Jarek Potiuk
> Priority: Major
>
> We had to sets of duplicated local volume mounts - one for ./breeze
> interactive runs (with docker_compose) and the other with scripts that are
> used to run static checks.
> The volumes from the .yaml for docker compose should be the "source of truth"
> and the bash script should parse the yaml and use volume mounts from there.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
