kaxil commented on code in PR #69933:
URL: https://github.com/apache/airflow/pull/69933#discussion_r3624557643
##########
airflow-core/tests/unit/utils/test_task_group.py:
##########
@@ -719,25 +721,27 @@ def section_2(value2):
assert dag.task_dict["section_1.section_2.task_4"].downstream_task_ids ==
{"task_end"}
# Node IDs test
+ # task_start feeds section_1.task_1 directly (a task-level dep crossing
into the
+ # group), so section_1 must sort after task_start, not before it.
node_ids = {
"id": None,
"children": [
+ {"id": "task_start"},
{
"id": "section_1",
"children": [
+ {"id": "section_1.task_1"},
+ {"id": "section_1.task_2"},
{
"id": "section_1.section_2",
"children": [
{"id": "section_1.section_2.task_3"},
{"id": "section_1.section_2.task_4"},
],
},
- {"id": "section_1.task_1"},
Review Comment:
cc @uranusjr Since I distinctly remember TP fixing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
