kaxil commented on code in PR #70070:
URL: https://github.com/apache/airflow/pull/70070#discussion_r3624712610
##########
providers/common/ai/tests/unit/common/ai/plugins/test_hitl_review.py:
##########
@@ -383,14 +382,14 @@ def test_read_xcom_by_prefix_agent_output_formats(self,
session, dag_maker, outp
dag_maker.create_dagrun(run_id="r", run_type=DagRunType.MANUAL,
logical_date=logical_date)
dag_maker.sync_dagbag_to_db()
- XComModel.set(
+ _write_xcom(
Review Comment:
Both `_write_xcom` and `_read_xcom` are under test here, so this pins them
as a symmetric pair rather than against the actual worker write path -- a
symmetric reintroduction of double-encoding in both helpers would still pass.
It does catch a read-only regression (seeding natively + the old
`deserialize_value` read fails on the JSON-string cases), but asserting the raw
stored `XComModel.value` in one case (that it's a native str/dict, not a
JSON-encoded string) would independently pin the on-disk format workers produce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
