haseebmalik18 commented on code in PR #70152:
URL: https://github.com/apache/airflow/pull/70152#discussion_r3625727959
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/datasync.py:
##########
@@ -181,7 +192,7 @@ def __init__(
if self.source_location_uri and self.destination_location_uri:
valid = True
if not valid:
- raise AirflowException(
+ raise ValueError(
Review Comment:
Yeah, intentional. The constructor check is argument validation, so
ValueError fits it better, while the execute failures stay AirflowException
subclasses. It's also at parse time where the DAG loader catches broad
Exception, so a bad config still surfaces as a normal import error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
