MaksYermak commented on code in PR #66952:
URL: https://github.com/apache/airflow/pull/66952#discussion_r3629528021
##########
scripts/in_container/run_provider_yaml_files_check.py:
##########
@@ -978,12 +978,13 @@ def check_doc_files(yaml_files: dict[str, dict]) ->
tuple[int, int]:
if f.name != "index.rst" and "_partials" not in f.parts and f.parts[2]
== "docs"
}
- expected_doc_urls = {
- doc_url
- for doc_url in expected_doc_urls
- for suspend_provider in suspended_providers
- if suspend_provider not in doc_url
- }
+ if suspended_providers:
Review Comment:
@gopidesupavan this `if-clause` is needed because in case when
`suspended_providers` is empty. This code:
```
expected_doc_urls = {
doc_url
for doc_url in expected_doc_urls
for suspend_provider in suspended_providers
if suspend_provider not in doc_url
}
```
rewrite `expected_doc_urls` and assign `{}` as a value and as a result broke
CI tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
