[
https://issues.apache.org/jira/browse/AIRFLOW-6467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008437#comment-17008437
]
ASF GitHub Bot commented on AIRFLOW-6467:
-----------------------------------------
mustafagok commented on pull request #7067: [AIRFLOW-6467] Use self.dag i/o
creating a new one
URL: https://github.com/apache/airflow/pull/7067
In this unit test method, self.dag can be used instead of creating a local
variable named "dag".
---
Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6467
- [x] Description above provides context of the change
- [x] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA
ID*
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
(*) For document-only changes, no JIRA issue is needed. Commit message
starts `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove unnecessary local variable
> ---------------------------------
>
> Key: AIRFLOW-6467
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6467
> Project: Apache Airflow
> Issue Type: Test
> Components: tests
> Affects Versions: 1.10.7
> Reporter: Mustafa Gök
> Assignee: Mustafa Gök
> Priority: Trivial
>
> In test_templated_sensor (tests/sensors/test_external_task_sensor.py) unit
> test method, self.dag can be used instead of creating a local variable named
> "dag" (line 98).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
