Miretpl commented on code in PR #69954:
URL: https://github.com/apache/airflow/pull/69954#discussion_r3633441584
##########
chart/values.schema.json:
##########
@@ -1315,6 +1315,14 @@
],
"default": null
},
+ "metadataSecretKey": {
+ "description": "Key in the metadata connection secret
containing the connection string. Only used when `metadataSecretName` is set.
Defaults to `connection`.",
Review Comment:
```suggestion
"description": "Key in the metadata connection secret
containing the connection string. Only used when `metadataSecretName` is set.",
```
The parameter itself defaults to `null`, which will albo be visible in the
generation documentation under the parameters section, so specifying that the
default underneath is `connection` would be misleading for the documentation
reader. If I remember correctly, in the `values.yaml` there is information that
`connection` is the required key next to proper configuration options and I
think that it is correct place for it.
##########
chart/values.schema.json:
##########
@@ -1323,6 +1331,14 @@
],
"default": null
},
+ "resultBackendSecretKey": {
+ "description": "Key in the result backend connection
secret containing the connection string. Only used when
`resultBackendSecretName` is set. Defaults to `connection`.",
Review Comment:
```suggestion
"description": "Key in the result backend connection
secret containing the connection string. Only used when
`resultBackendSecretName` is set.",
```
##########
chart/values.yaml:
##########
@@ -445,13 +445,24 @@ data:
# postgresql+psycopg2://airflow:password@postgres/airflow
metadataSecretName: ~
+ # When `metadataSecretName` is set, the key in that secret containing the
connection string.
+ # Useful when the secret is managed externally, e.g. CloudNativePG stores
the URI under the "uri" key.
+ metadataSecretKey: ~
+
# If not set, falls back to metadataSecretName. The secret must contain
'connection' key which is
# a base64-encoded connection string, e.g.:
# postgresql+psycopg2://user:password@host/db
resultBackendSecretName: ~
+ # When `resultBackendSecretName` is set, the key in that secret containing
the result backend
Review Comment:
```suggestion
# When `resultBackendSecretName` is set, the key in that secret contains
the result backend
```
##########
chart/values.yaml:
##########
@@ -445,13 +445,24 @@ data:
# postgresql+psycopg2://airflow:password@postgres/airflow
metadataSecretName: ~
+ # When `metadataSecretName` is set, the key in that secret containing the
connection string.
+ # Useful when the secret is managed externally, e.g. CloudNativePG stores
the URI under the "uri" key.
+ metadataSecretKey: ~
+
# If not set, falls back to metadataSecretName. The secret must contain
'connection' key which is
# a base64-encoded connection string, e.g.:
# postgresql+psycopg2://user:password@host/db
resultBackendSecretName: ~
+ # When `resultBackendSecretName` is set, the key in that secret containing
the result backend
+ # connection string.
+ resultBackendSecretKey: ~
+
brokerUrlSecretName: ~
+ # When `brokerUrlSecretName` is set, the key in that secret containing the
broker URL.
Review Comment:
```suggestion
# When `brokerUrlSecretName` is set, the key in that secret contains the
broker URL.
```
##########
chart/values.schema.json:
##########
@@ -1332,6 +1348,15 @@
"x-docsSection": "Redis",
"default": null
},
+ "brokerUrlSecretKey": {
+ "description": "Key in the broker URL secret containing
the broker URL. Only used when `brokerUrlSecretName` is set. Defaults to
`connection`.",
Review Comment:
```suggestion
"description": "Key in the broker URL secret containing
the broker URL. Only used when `brokerUrlSecretName` is set.",
```
##########
chart/values.yaml:
##########
@@ -445,13 +445,24 @@ data:
# postgresql+psycopg2://airflow:password@postgres/airflow
metadataSecretName: ~
+ # When `metadataSecretName` is set, the key in that secret containing the
connection string.
+ # Useful when the secret is managed externally, e.g. CloudNativePG stores
the URI under the "uri" key.
Review Comment:
```suggestion
# When `metadataSecretName` is set, the key in that secret contains the
connection string.
# Useful when the secret is managed externally, e.g. CloudNativePG stores
the URI under the "uri" key.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
