pranayyelugam commented on code in PR #70213:
URL: https://github.com/apache/airflow/pull/70213#discussion_r3634617039
##########
chart/templates/_helpers.yaml:
##########
@@ -87,7 +87,8 @@ If release name contains chart name it will be used as a full
name.
{{- $triggererKedaEnabled := and .Values.triggerer.enabled
.Values.triggerer.keda.enabled }}
{{- $workersKedaNeedsDbConn := and .Values.workers.celery.keda.enabled (or
(eq .Values.data.metadataConnection.protocol "mysql") (and
.Values.pgbouncer.enabled (not .Values.workers.celery.keda.usePgbouncer))) }}
{{- $triggererKedaNeedsDbConn := and $triggererKedaEnabled (or (eq
.Values.data.metadataConnection.protocol "mysql") (and
.Values.pgbouncer.enabled (not .Values.triggerer.keda.usePgbouncer))) }}
- {{- if or $workersKedaNeedsDbConn $triggererKedaNeedsDbConn }}
+ {{- $component := .Component | default "" }}
+ {{- if or (and (eq $component "worker") $workersKedaNeedsDbConn) (and (eq
$component "triggerer") $triggererKedaNeedsDbConn) }}
Review Comment:
I moved the KEDA connection out of standard_airflow_environment into a
dedicated keda_airflow_environment helper, pulled in only by the worker and
triggerer deployments.
On the helper's shape: I kept the logic (MySQL, or bypassing PgBouncer) and
the worker-vs-triggerer selection inside the helper rather than making it dumb
to avoid pushing that condition into both deployment templates and repeat it at
each call site
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
