amoghrajesh opened a new pull request, #70291:
URL: https://github.com/apache/airflow/pull/70291
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes: claude sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
### What
Follow-up to https://github.com/apache/airflow/pull/70289, which added
`__supports_durable_execution: ClassVar[bool] = True` directly to
`KubernetesPodOperator` and `AgentOperator` both of which implement crash-safe
execution against `task_state_store` without inheriting `ResumableJobMixin`.
That attribute wasn't read by anything yet; the Registry's
`is_durable_capable()` only checked for `ResumableJobMixin` in the MRO, so both
operators stayed invisible to the badge despite genuinely qualifying.
### Current behaviour
`is_durable_capable()` in `dev/registry/extract_parameters.py` only
qualifies a class via the `ResumableJobMixin` structural check (inherits it,
all abstract methods overridden, `execute_resumable` reachable from
`execute()`). Classes that implement durable execution some other way have no
path to qualify.
### Proposed change
Adds a second, independent qualifying path: `is_durable_capable()` now also
checks for a class level `__supports_durable_execution = True` declaration.
Because the attribute name uses a double leading underscore, Python name
mangles it to `_{ClassName}__supports_durable_execution` on whichever class
declares it. The check computes that mangled name per class being inspected
(`f"_{cls.__name__}__supports_durable_execution"`) rather than a fixed string,
so it only matches the exact class that wrote the declaration in its own body
-- not any subclass that merely inherits from it.
### Changes of Note
This distinction matters concretely: `KubernetesPodOperator` has real
subclasses (`SparkKubernetesOperator`, `KubernetesJobOperator`,
`KubernetesStartKueueJobOperator`) that override `execute()` themselves.
Nothing verifies those overrides preserve the `task_state_store` reconnect
behavior yet, so the marker must not propagate to them automatically.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
