pierrejeambrun commented on code in PR #69955:
URL: https://github.com/apache/airflow/pull/69955#discussion_r3637186108
##########
airflow-core/src/airflow/ui/src/components/FilterBar/filters/DateRangeFilter.tsx:
##########
@@ -64,6 +65,12 @@ export const DateRangeFilter = ({ filter, onChange, onRemove
}: FilterPluginProp
defaultOpen={!hasValue}
key={filter.id}
lazyMount
+ onOpenChange={(details) => {
+ if (!details.open) {
+ // Submit the current editing state when the popover closes
+ applyDateRange();
+ }
+ }}
Review Comment:
applyDateRange fires on every popover close. (Even when no edit has been
done, a cheap check on the value could prevent this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
