guan404ming commented on code in PR #70085:
URL: https://github.com/apache/airflow/pull/70085#discussion_r3638038258
##########
ts-sdk/src/coordinator/log-channel.ts:
##########
@@ -66,22 +67,39 @@ export class LogChannel {
this.isRoot = isRoot;
}
+ /** Create a root channel with no socket yet; records are buffered
+ * until {@link LogChannel#connect} flushes them. */
+ static createBuffered(name: string = DEFAULT_LOGGER_NAME): LogChannel {
+ return new LogChannel({ sock: null, connected: false, closed: false,
buffer: [] }, name, true);
+ }
+
static async connect(addr: string, name: string = DEFAULT_LOGGER_NAME):
Promise<LogChannel> {
Review Comment:
Make sense to me, just dropped it. I think the tests could use a local
`connectChannel()` helper instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
