guan404ming commented on code in PR #70299:
URL: https://github.com/apache/airflow/pull/70299#discussion_r3638814718
##########
providers/common/ai/src/airflow/providers/common/ai/operators/document_loader.py:
##########
@@ -219,18 +222,29 @@ def _resolve_remote_files(self, source_path: str) ->
list[FilePathT]:
pass
if not root.is_dir():
- raise FileNotFoundError(
- f"Cloud URI '{source_path}' is neither a file nor a directory.
"
- "Cross-directory globs in cloud URIs aren't supported here; "
- "point ``source_path`` at a single object or a directory."
- )
+ raise FileNotFoundError(f"Cloud URI '{source_path}' is neither a
file nor a directory.")
candidates = sorted(
(p for p in root.iterdir() if not p.name.startswith(".")),
key=str,
)
return self._filter_files([p for p in candidates if p.is_file()],
is_directory_mode=True)
+ def _resolve_remote_glob(self, source_path: str) -> list[FilePathT]:
+ from airflow.sdk import ObjectStoragePath
Review Comment:
Sure, great catch thanks. Just updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
