tailg8nj commented on code in PR #69633:
URL: https://github.com/apache/airflow/pull/69633#discussion_r3640039700
##########
shared/observability/tests/observability/test_traces.py:
##########
@@ -43,6 +43,23 @@ def _carrier_is_sampled(carrier: dict[str, str]) -> bool:
return trace.get_current_span(ctx).get_span_context().trace_flags.sampled
+def _carrier_span_context(carrier: dict[str, str]):
+ ctx = TraceContextTextMapPropagator().extract(carrier)
Review Comment:
Should this instead be:
```suggestion
ctx = extract(carrier)
```
or `get_global_textmap().extract(carrier)`
So that distros and configurations can leverage their own?
https://github.com/open-telemetry/opentelemetry-python/blob/684b19d3748d3f362cbe2d06c3caad9cbde8edef/opentelemetry-api/src/opentelemetry/propagate/__init__.py#L173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
