michaelpri10 commented on code in PR #67621:
URL: https://github.com/apache/airflow/pull/67621#discussion_r3641335222
##########
providers/google/src/airflow/providers/google/cloud/hooks/pubsub.py:
##########
@@ -712,6 +721,15 @@ async def pull(
the base64-encoded message content. See
https://cloud.google.com/pubsub/docs/reference/rpc/google.pubsub.v1#google.pubsub.v1.ReceivedMessage
"""
+ if return_immediately is not None:
+ warnings.warn(
+ "The `return_immediately` parameter is deprecated and will be
removed in a future release.",
+ AirflowProviderDeprecationWarning,
+ stacklevel=2,
+ )
Review Comment:
Given that the `PubSubHook` class already has `False` as the default value,
the updated deprecation warning no longer applies here, so I've undone the
changes to this class (and its test class).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
