mik-laj commented on a change in pull request #6993: [AIRFLOW-4502] new cli
command - task_states_for_dag_run
URL: https://github.com/apache/airflow/pull/6993#discussion_r363127597
##########
File path: tests/cli/commands/test_task_command.py
##########
@@ -184,6 +184,10 @@ def test_task_state(self):
'tasks', 'state', 'example_bash_operator', 'runme_0',
DEFAULT_DATE.isoformat()]))
+ def test_task_states_for_dag_run(self):
+ task_command.task_states_for_dag_run(self.parser.parse_args([
Review comment:
Can you add some assertions? I see that other tests do not have, but we are
trying to improve the CLI now and I have already [made many
changes](https://github.com/apache/airflow/pulls?q=is%3Apr+label%3Aarea%3ACLI+is%3Aclosed+author%3Amik-laj)
that do it.
Here is sample of assertions in tests:
https://github.com/apache/airflow/blob/master/tests/cli/commands/test_config_command.py#L38
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
