shahar1 opened a new pull request, #70391:
URL: https://github.com/apache/airflow/pull/70391
related: #70345
## Human Summary
I had some concerns regarding `_hitl_summary_extra` being a private
dictionary after I merged the above.
As the docs state that subclasses can extand HITLOperator, probably it's
better as a public attribute.
## AI Summary
#70345 turned `hitl_summary` into a computed property (so templated
`subject`/`body` are read after rendering) and moved runtime/subclass additions
into a private `_hitl_summary_extra` dict. That left `HITLOperator` subclasses
without a supported way to extend the summary — the pattern the old attribute
explicitly documented ("subclasses can extend it") now silently mutates a
throwaway snapshot — and it leaks the private attribute name into OpenLineage
`include_full_task_info` events (which serialize the operator's `__dict__`,
where a property never appears).
This renames the dict to a public `hitl_summary_extra` and documents the
contract on the property: each access builds a fresh snapshot, mutation of the
returned dict has no effect, and extensions go through `hitl_summary_extra`.
Since #70345 has not shipped in a provider release yet, the rename is free of
compatibility cost — waiting until after the next provider wave would turn it
into a real break.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Fable 5)
Generated-by: Claude Code (Fable 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
