potiuk commented on code in PR #70396:
URL: https://github.com/apache/airflow/pull/70396#discussion_r3653202273
##########
dev/breeze/tests/test_release_management_commands.py:
##########
@@ -292,3 +293,18 @@ def
test_get_package_version_possibly_from_stable_txt_for_java_sdk(
stable_txt.parent.mkdir(parents=True)
stable_txt.write_text(stable_txt_content)
assert get_package_version_possibly_from_stable_txt("java-sdk") ==
expected_version
+
+
[email protected](
+ ("body", "expected"),
+ [
+ ("Some description closes: #12345 and more text", [12345]),
+ # reference at the very end of the body (e.g. "Fixes #53843" as the
last line)
+ ("Generated-by: some agent Fixes #53843", [53843]),
+ ("related: #111, also see #222", [111, 222]),
Review Comment:
nit, optional — the fix also cures adjacent references, since the old
`[^0-9]` consumed the separator that the next match needed. A case pinning that
behaviour down:
```suggestion
("related: #111, also see #222", [111, 222]),
("adjacent references see #111 #222", [111, 222]),
```
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -256,7 +256,7 @@
SOURCE_DIR_PATH = str(AIRFLOW_ROOT_PATH)
PR_PATTERN = re.compile(r".*\(#([0-9]+)\)")
PR_REFERENCE_PATTERN = re.compile(r"#([0-9]+)")
-ISSUE_MATCH_IN_BODY = re.compile(r" #([0-9]+)[^0-9]")
+ISSUE_MATCH_IN_BODY = re.compile(r" #([0-9]+)(?![0-9])")
Review Comment:
nit — `dev/assign_cherry_picked_prs_with_milestone.py:50` still carries a
byte-identical copy of the *old* pattern. I checked: it's dead code there —
defined but never referenced in that file — so nothing is actually broken. But
it now diverges from this one, and it's the first hit anyone gets greping for
`ISSUE_MATCH_IN_BODY`. Deleting it in this PR would save the next person the
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
