potiuk commented on PR #70419: URL: https://github.com/apache/airflow/pull/70419#issuecomment-5084986091
Thanks for these three — all approved for `v3-3-test`. One follow-up worth doing while the context is fresh. All three PRs (#70417, #70418, #70419) target `v3-3-test` only, and the same gaps are still open on `main`. Comparing `en` against `zh-CN` there as of today: | namespace | missing keys | |---|---| | `common` | 64 | | `dashboard` | 10 | | `hitl` | 8 | | `dags` | 7 | | `components` | 2 | | `admin` | 1 | That's 92 keys — more than these PRs add here, because `main` has picked up newer English strings on top of the ones you're filling for 3.3.1. The consequence is that these translations ship in 3.3.1 and then go missing again in 3.4, since 3.4 releases from `main`. Every other translation effort currently in flight targets `main` — Polish (#70476), Arabic (#70383), Korean (#70211), French (#70386) — and French additionally opened #70387 as its `v3-3-test` counterpart, which is the pattern worth copying: land on `main` first, then backport to the release branch. Right now zh-CN is the only language going release-branch-only. Nothing to change on these three — they're good for the RC. But could you open a companion PR against `main` covering the same namespaces? The full 92-key set would be ideal, though even porting just what's in these three would be a clear improvement. If you'd rather not take it on, let us know and we can look for someone else to pick it up. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
